From 7612f74bcbe1f0f2639a06a12f69fba8144efcf0 Mon Sep 17 00:00:00 2001
From: Pim Nelissen <pim.nelissen@protonmail.com>
Date: Tue, 3 Mar 2026 20:59:15 +0100
Subject: [PATCH] rename eff to efficiency

---
 src/pg_rad/detector/builder.py   |  2 +-
 src/pg_rad/detector/detectors.py | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/pg_rad/detector/builder.py b/src/pg_rad/detector/builder.py
index cf5a6e8..940a2f9 100644
--- a/src/pg_rad/detector/builder.py
+++ b/src/pg_rad/detector/builder.py
@@ -14,7 +14,7 @@ class DetectorBuilder:
         if self.detector_spec.is_isotropic:
             return IsotropicDetector(
                 self.detector_spec.name,
-                self.detector_spec.eff
+                self.detector_spec.efficiency
             )
         else:
             raise NotImplementedError("Angular detector not supported yet.")
diff --git a/src/pg_rad/detector/detectors.py b/src/pg_rad/detector/detectors.py
index cb4ec1f..439ee56 100644
--- a/src/pg_rad/detector/detectors.py
+++ b/src/pg_rad/detector/detectors.py
@@ -5,10 +5,10 @@ class BaseDetector(ABC):
     def __init__(
         self,
         name: str,
-        eff: float
+        efficiency: float
     ):
         self.name = name
-        self.eff = eff
+        self.efficiency = efficiency
 
     def get_efficiency(self):
         pass
@@ -18,21 +18,21 @@ class IsotropicDetector(BaseDetector):
     def __init__(
         self,
         name: str,
-        eff: float | None = None
+        efficiency: float,
     ):
-        super().__init__(name, eff)
+        super().__init__(name, efficiency)
 
     def get_efficiency(self, energy):
-        return self.eff
+        return self.efficiency
 
 
 class AngularDetector(BaseDetector):
     def __init__(
         self,
         name: str,
-        eff: float | None = None
+        efficiency: float
     ):
-        super().__init__(name, eff)
+        super().__init__(name, efficiency)
 
     def get_efficiency(self, angle, energy):
         pass